-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sigs.k8s.io/bom to v0.6.0 and drop build for linux/s390x and windows/386 #3530
Conversation
a294058
to
12df84c
Compare
opened an issue for the deps review job to figure out what is going on: actions/dependency-review-action#736 but this is a non-blocking job so we can merge that |
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
12df84c
to
bb8a11d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override dependency-review |
@cpanato: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/skip |
@cpanato should we merge manually here? |
i think so, lets do that |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
/assign @puerco @xmudrii @saschagrunert
cc @kubernetes/release-managers
from: #3419 (comment)
https://gitlab.com/cznic/sqlite/-/issues/169
So we are dropping the
windows/386
because of lack of support and also forlinux/s390x
which maybe we dont have any release managers using that platformWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?