Skip release archive #3717
Merged
Skip release archive #3717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XXL
saschagrunert
force-pushed
the
archive
branch
2 times, most recently
from
24f07c5 to
c0b8dd3
Compare
saschagrunert
force-pushed
the
archive
branch
3 times, most recently
from
898b58a to
5e77b9d
Compare
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
Don't archive the release any more and move the announcement to the release artifacts (`kubernetes-release/release/v1.x.y`). Signed-off-by: Sascha Grunert <[email protected]>
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
I don't think we need to write the log files, I can follow-up on that. PTAL @kubernetes/release-engineering |
ameukam
reviewed
Aug 21, 2024
| @@ -117,7 +117,7 @@ func runAnnounce(opts *sendAnnounceOptions, announceRootOpts *announceOptions, r | |||
|
|
|||
| tag := util.AddTagPrefix(announceRootOpts.tag) | |||
| u := fmt.Sprintf( | |||
| "%s/archive/anago-%s/announcement.html", | |||
| "%s/release/%s/announcement.html", | |||
There was a problem hiding this comment.
Switching this is not impactful for the patch releases ?
There was a problem hiding this comment.
It impacts everything, patches and minors.
|
/lgtm In case other releng folx want to chime in. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@kubernetes/release-engineering PTAL |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind deprecation
What this PR does / why we need it:
Don't archive the release any more and move the announcement to the release artifacts (
kubernetes-release/release/v1.x.y).Which issue(s) this PR fixes:
Fixes #3716
Special notes for your reviewer:
Test run: https://console.cloud.google.com/cloud-build/builds/30395f84-a680-4315-a144-7049da5f7805
Output: https://console.cloud.google.com/storage/browser/kubernetes-release-gcb/release/v1.31.1
Does this PR introduce a user-facing change?