Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build krel from sources when not using default TOOL_* values #3718

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Build krel from sources when not using default TOOL_* values #3718

merged 1 commit into from
Aug 21, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 21, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This allos testing GCB by setting one of TOOL_ORG, TOOL_REPO or TOOL_REF.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Follow-up on #3359

Does this PR introduce a user-facing change?

GCB: build `krel` from sources when not using default `TOOL_*` environment variables.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 21, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 21, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 21, 2024
@saschagrunert saschagrunert changed the title Build krel from sources when not using default TOOL_* values WIPBuild krel from sources when not using default TOOL_* values Aug 21, 2024
@saschagrunert saschagrunert changed the title WIPBuild krel from sources when not using default TOOL_* values WIP: Build krel from sources when not using default TOOL_* values Aug 21, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2024
@saschagrunert saschagrunert force-pushed the krel-sources branch 2 times, most recently from 05124ba to 501b877 Compare August 21, 2024 10:18
@saschagrunert saschagrunert changed the title WIP: Build krel from sources when not using default TOOL_* values Build krel from sources when not using default TOOL_* values Aug 21, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2024
@saschagrunert
Build krel from sources when not using default TOOL_* values
1de3359 
This allos testing GCB by setting one of `TOOL_ORG`, `TOOL_REPO` or
`TOOL_REF`.

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2024
@saschagrunert
Copy link
Member Author

@cpanato rebased.

@saschagrunert
Copy link
Member Author

@kubernetes/release-engineering PTAL

cpanato
cpanato requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a53bb39 into kubernetes:master Aug 21, 2024
11 checks passed
@saschagrunert saschagrunert deleted the krel-sources branch August 21, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato requested changes

@jimangel jimangel Awaiting requested review from jimangel

@salaxander salaxander Awaiting requested review from salaxander

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @k8s-ci-robot @cpanato