Skip to content

Conversation

@ComradeProgrammer
Copy link
Member

Following https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md
Changes are also being made simultaneously on minikube side kubernetes/minikube#21904
(There will be a file called hack/prow/image/kubernetes-bootcamp/cloudbuild.yaml in minikube)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ComradeProgrammer
Once this PR has been reviewed and has the lgtm label, please assign genpage for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 16, 2025
@ComradeProgrammer
Copy link
Member Author

We are trying to migrate some simple image to k8s registry, so we just chose the easiest one. If this works, we will migrate more of them.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2025
@medyagh
Copy link
Member

medyagh commented Nov 18, 2025

/lgtm

command:
- /run.sh
args:
- --project=k8s-staging-minikube
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- --project=k8s-staging-minikube
- --project=k8s-staging-images

to match https://github.com/kubernetes/k8s.io/blob/main/infra/gcp/terraform/k8s-staging-images/registries.tf#L42

- /run.sh
args:
- --project=k8s-staging-minikube
- --scratch-bucket=gs://k8s-staging-minikube-gcb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- --scratch-bucket=gs://k8s-staging-minikube-gcb
- --scratch-bucket=gs://k8s-staging-images-gcb

@BenTheElder
Copy link
Member

/cc @kubernetes/sig-k8s-infra-leads

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: GitHub didn't allow me to request PR reviews from the following users: kubernetes/sig-k8s-infra-leads.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kubernetes/sig-k8s-infra-leads

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants