-
Notifications
You must be signed in to change notification settings - Fork 2.8k
add minikube bootcamp image to registry #35928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add minikube bootcamp image to registry #35928
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ComradeProgrammer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We are trying to migrate some simple image to k8s registry, so we just chose the easiest one. If this works, we will migrate more of them. |
03a5945 to
7980ace
Compare
|
/lgtm |
| command: | ||
| - /run.sh | ||
| args: | ||
| - --project=k8s-staging-minikube |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - --project=k8s-staging-minikube | |
| - --project=k8s-staging-images |
| - /run.sh | ||
| args: | ||
| - --project=k8s-staging-minikube | ||
| - --scratch-bucket=gs://k8s-staging-minikube-gcb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - --scratch-bucket=gs://k8s-staging-minikube-gcb | |
| - --scratch-bucket=gs://k8s-staging-images-gcb |
|
/cc @kubernetes/sig-k8s-infra-leads |
|
@BenTheElder: GitHub didn't allow me to request PR reviews from the following users: kubernetes/sig-k8s-infra-leads. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Following https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md
Changes are also being made simultaneously on minikube side kubernetes/minikube#21904
(There will be a file called hack/prow/image/kubernetes-bootcamp/cloudbuild.yaml in minikube)