Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: start moving the resource management docs to concepts #48797

Open
wants to merge 1 commit into
base: dev-1.32
Choose a base branch
from

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented Nov 21, 2024

Description

Move the cpu management policies and options docs from tasks to concepts
xref: #48340 (review)

In the 1.32 cycle I don't have capacity to move except for CPU manager, which is the worst offender anyway. Other managers should follow suite, hopefully in the 1.33 cycle already.

Issue

Closes: #38121 (albeit in a different and IMO better way)

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Nov 21, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 21, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 21, 2024
Copy link

netlify bot commented Nov 21, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 84d616d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/673f1cb37f4e95000808f924

@ffromani ffromani changed the title node: move resource management docs to concepts node: start moving the resource management docs to concepts Nov 21, 2024
We have reached a point where the existing CPU management task page is quite hard to follow.
Start moving the resource management concepts to the concept page.

We begin with the CPU management policies, the worst offender right now.
Over time, the plan is to move all the concepts from tasks in the
concepts page.

Signed-off-by: Francesco Romani <[email protected]>
Copy link

netlify bot commented Nov 21, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit dbdd3ec
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/673f1c378d677600096cf597
😎 Deploy Preview https://deploy-preview-48797--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 21, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 84d616d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/673f1cb49f654200082aced6
😎 Deploy Preview https://deploy-preview-48797--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented Nov 21, 2024

Totally agree to this refactoring, however, I'd suggest we postpone this because 1.32 is about to be released soon. Propagating this change to localization teams takes some time.

@ffromani
Copy link
Contributor Author

Totally agree to this refactoring, however, I'd suggest we postpone this because 1.32 is about to be released soon. Propagating this change to localization teams takes some time.

cc @sftim so we go ahead with #48340 as-is?

@ffromani
Copy link
Contributor Author

also note this change will impact PRs #48469 and #48356 other than #48340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants