fix: Display managed clusters when itsData is null #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add fallback to show local clusters - Convert contexts to managed cluster format - Add ContextInfo interface
|
@clubanderson can you review this |
|
hey @MAVRICK-1 can you help me in joining the slack can you send me invitation it would be very helpful? |
|
@krishkumar84 Thank you for the PR. Unfortunately the ITS managedcluster list does not include the "kubeflex" clusters. ITS is the KubeStellar inventory and transport service. Any object in an ITS of type managedcluster is what belongs in this dialog. |
|
@krishkumar84 I opened a ticket with CNCF for their slack inviter being down. |
|
@krishkumar84 the link for CNCF invite is working now |
|
@krishkumar84 are there other issues you would like to work on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display managed clusters when itsData is null
Description
This PR implements a fallback mechanism to display local Kubernetes clusters in the Managed Clusters page when itsData is null. Previously, the page would show an empty table even when valid local clusters were present.
Related Issue
Fixes #163
Changes Made
Checklist
Screenshots or Logs (if applicable)
Before:
After:
Additional Notes
This change improves the developer experience by showing local clusters during development, while maintaining compatibility with the existing itsData structure.