Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new components and modified WDS page #94

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

onkar717
Copy link
Contributor

@onkar717 onkar717 commented Feb 8, 2025

This PR introduces a new Create Workload feature in WDS, allowing users to apply workloads using three methods , Workload Status , Deployment Staus Tabel:

Write YAML/JSON manually.
Upload a file from their PC.
Use a form to create workloads interactively.
Additionally, it includes features for:

Workload status tracking
Viewing running deployments, services, etc.
A Deployment Table to display all deployment data.

Related Issue

Partially addresses #51

Implement a WDS frontend supported by WDS backend endpoints.

Changes Made
Added Create Workload feature with three input methods.
Implemented Workload Status tracking.
Created a Deployment Table to display deployment data.
Improved UI/UX for workload management.

Checklist
✅ I have reviewed the project's contribution guidelines.
✅ I have tested the changes locally and ensured they work as expected.
✅ My code follows the project's coding standards.

@clubanderson
Copy link
Contributor

@onkar717 this breaks the build. There is a lint error. One of the bars you introduced is not used. Just comment out that bar and commit/push again.

setHasUnsavedChanges,
onCancel,
}: Props) => {
const [yamlContent, setYamlContent] = useState("");
Copy link
Member

@manzil-infinity180 manzil-infinity180 Feb 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const [yamlContent, setYamlContent] = useState("");
// eslint-disable-next-line no-unused-vars
const [yamlContent, setYamlContent] = useState("");

add the eslint comment for this unused vars

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@manzil-infinity180
Copy link
Member

manzil-infinity180 commented Feb 8, 2025

@onkar717 you just need one eslint comment ( // eslint-disable-next-line no-unused-vars) above the unused variables line and what I see you have commented a lot of code

Fix it

@clubanderson clubanderson merged commit 3120ad9 into kubestellar:dev Feb 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants