Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a quesiton mark to the text msg of the Plan VMs Delete Modal #1356

Merged

Conversation

sgratch
Copy link
Collaborator

@sgratch sgratch commented Oct 15, 2024

Add a missing question mark to the end of text message displayed in the Plan's delete vms popup.

Before

Screenshot from 2024-10-15 14-45-50

After

Screenshot from 2024-10-15 14-41-23

Copy link

sonarcloud bot commented Oct 15, 2024

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.20%. Comparing base (13484d0) to head (c7fa74e).
Report is 84 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
- Coverage   36.81%   36.20%   -0.61%     
==========================================
  Files         158      158              
  Lines        2548     2574      +26     
  Branches      599      600       +1     
==========================================
- Hits          938      932       -6     
- Misses       1428     1640     +212     
+ Partials      182        2     -180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sgratch sgratch requested a review from yaacov October 15, 2024 11:56
@sgratch sgratch merged commit 17e439c into kubev2v:main Oct 15, 2024
8 of 9 checks passed
@sgratch sgratch deleted the add-question-mark-to-plan-delete-vm-msg branch October 15, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants