User domain name to domain name #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yzamir <[email protected]>
yaacov
force-pushed
the
user-domain-name-to-domain-name
branch
from
b84b464
to
e7ad1b2
Compare
|
SonarCloud Quality Gate failed.
|
mmartinv
reviewed
Jul 21, 2023
| @@ -42,9 +42,6 @@ export const openstackSecretFieldValidator = (id: string, value: string) => { | |||
| case 'projectID': | |||
| validationState = validateProjectID(trimmedValue) ? 'success' : 'error'; | |||
| break; | |||
| case 'userDomainName': | |||
| validationState = validateUserDomainName(trimmedValue) ? 'success' : 'error'; | |||
| break; | |||
There was a problem hiding this comment.
Shouldn't the domainName be validated? I see you dropped userDomainName validation but you didn't add the equivalent for domainName...
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #591
Issue:
When creating an OpenStack provider with Token with User Name authentication type, the domainName/domainId is needed in the secret, while the userDomainName is not a must.
Currently, there is no Domain Name filed on creating provider page, the provider will be in connectonfailed status. Need to change the User Domain Name field to Domain Name
Screenshot: