Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the fields shown in 'Credentials' tab in details page #597

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jul 21, 2023

Ref: #588

Issue:
In Provider details page, in Credentials tab
when a user created a secret using token ID or application ID - then will see the Name version
when a user created a secret using token Name or application Name - then will see the ID version

Problem:
the check was for !name then show name, should be for !name show ID

Fix:
change the if ... else for showing the fields

@yaacov yaacov added the bug Categorizes issue or PR as related to a bug. label Jul 21, 2023
@yaacov yaacov added this to the 2.5.0 milestone Jul 21, 2023
@yaacov yaacov force-pushed the fix-openstack-view-edit-fields-shown branch from 7d8d870 to f862f71 Compare July 21, 2023 14:38
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
45.8% 45.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@yaacov yaacov merged commit 27eb24c into kubev2v:main Jul 21, 2023
4 of 5 checks passed
@ahadas ahadas linked an issue Jul 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fields names are wrong on OpenStack Provider Details Credentials page
1 participant