Fix the gathering of importer and populator pods logs #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we moved to post the VM in the last phase, the VM now usually contains PVC in the volume spec instead of DV. We need to look on both in order to gather the relevant data. Signed-off-by: Liran Rotenberg <[email protected]>
ahadas
reviewed
Aug 17, 2023
ahadas
reviewed
Aug 17, 2023
liranr23
force-pushed
the
fix_gather
branch
from
7aaffce
to
381d3dc
Compare
ahadas
reviewed
Sep 12, 2023
liranr23
force-pushed
the
fix_gather
branch
from
381d3dc
to
0a5d421
Compare
Adding migrations IDs based on the VM label. This will allow us to gather the populator pod logs when there is no plan ID provided. Signed-off-by: Liran Rotenberg <[email protected]>
liranr23
force-pushed
the
fix_gather
branch
from
0a5d421
to
cc8825d
Compare
ahadas
approved these changes
Sep 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we moved to post the VM in the last phase, the VM now usually
contains PVC in the volume spec instead of DV. We need to look on both
in order to gather the relevant data.
Also, adding migrations IDs based on the VM label. This will allow us to
gather the populator pod logs when there is no plan ID provided.