converter: add progress #813
Open
+469
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
force-pushed
the
image-converter-progress
branch
from
fca403d
to
bcba0b8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #813 +/- ##
=========================================
+ Coverage 0 16.80% +16.80%
=========================================
Files 0 94 +94
Lines 0 19685 +19685
=========================================
+ Hits 0 3308 +3308
- Misses 0 16109 +16109
- Partials 0 268 +268
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bennyz
force-pushed
the
image-converter-progress
branch
4 times, most recently
from
760c3dd
to
ecc5469
Compare
bennyz
commented
Mar 20, 2024
| } | ||
|
|
||
| if workload.ImageID == "" { | ||
| //nolint:nilnil |
There was a problem hiding this comment.
perhaps I should use a sentinel error?
bennyz
force-pushed
the
image-converter-progress
branch
7 times, most recently
from
fed06f9
to
4aa4e01
Compare
Signed-off-by: Benny Zlotnik <[email protected]>
Signed-off-by: Benny Zlotnik <[email protected]>
Signed-off-by: Benny Zlotnik <[email protected]>
Signed-off-by: Benny Zlotnik <[email protected]>
bennyz
force-pushed
the
image-converter-progress
branch
from
4aa4e01
to
273882c
Compare
Signed-off-by: Benny Zlotnik <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.