Enable SecureExecution feature gate by default

[jschintag]

What this PR does / why we need it:

Enable the SecureExecution feature gate in kubevirt. This allows Clusters to use Secure Execution VMs on IBM Z

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

• PR Message
• Commit Messages
• How to test
• Unit Tests
• Functional Tests
• User Documentation
• Developer Documentation
• Upgrade Scenario
• Uninstallation Scenario
• Backward Compatibility
• Troubleshooting Friendly

Jira Ticket:

Release note:

Enable SecureExecution Feature for s390x

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nunnatsa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[nunnatsa]

Thanks for the PR @jschintag

This FG is still alpha in KubeVirt 1.6.0. We can't enable alpha FGs by default.

/hold

[nunnatsa]

/hold

[coveralls]

Pull Request Test Coverage Report for Build 15845743809

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 72.907%

---

Totals
Change from base Build 15806328462:	0.0%
Covered Lines:	6566
Relevant Lines:	9006

---

💛 - Coveralls

[jschintag]

Thanks for the PR @jschintag

This FG is still alpha in KubeVirt 1.6.0. We can't enable alpha FGs by default.

If it is not possible by default, then this means i have to add it as a FeatureGate to HCO right?

[nunnatsa]

If it is not possible by default, then this means i have to add it as a FeatureGate to HCO right?

Again, too soon.

The FGs in HCO are named fields. it was maybe a mistake, but it is what it is.

So adding an alpha FG to the HCO API is not something we can approve. For alpha FG, please use the json patch annotation: https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/docs/cluster-configuration.md#jsonpatch-annotations

[jschintag]

If it is not possible by default, then this means i have to add it as a FeatureGate to HCO right?

Again, too soon.

The FGs in HCO are named fields. it was maybe a mistake, but it is what it is.

So adding an alpha FG to the HCO API is not something we can approve. For alpha FG, please use the json patch annotation: https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/docs/cluster-configuration.md#jsonpatch-annotations

Okay, thank you for the explanation

[openshift-ci]

@jschintag: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-kv-smoke-azure	9d0ffee	link	true	/test hco-e2e-kv-smoke-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[kubevirt-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.