Skip to content

Update VM lifecycle and node assignment docs: deprecate spec.running, document tolerations live update #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update VM lifecycle and node assignment docs: deprecate spec.running, document tolerations live update #927

wants to merge 1 commit into from

Conversation

vinay-852
Copy link

Resolves #923.

@kubevirt-bot kubevirt-bot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Sep 17, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jean-edouard for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 17, 2025
@kubevirt-bot
Copy link
Contributor

Hi @vinay-852. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vinay-852
Update VM lifecycle and node assignment docs: deprecate spec.running,…
39f9e77 
… document tolerations live update

Signed-off-by: Vinay Pepakayala <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Sep 17, 2025
@vinay-852
Copy link
Author

Hi @fabiand @victortoso,
The documentation changes for VM Lifecycle and RunStrategy are ready for review.
Please let me know if anything needs modification.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiand fabiand Awaiting requested review from fabiand

@victortoso victortoso Awaiting requested review from victortoso

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update VM Lifecycle and RunStrategy Documentation to Reflect Feature Lifecycle Changes
2 participants
@vinay-852 @kubevirt-bot