Update VM lifecycle and node assignment docs: deprecate spec.running, document tolerations live update #927
Conversation
kubevirt-bot
added
the
dco-signoff: no
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
needs-ok-to-test
|
Hi @vinay-852. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
… document tolerations live update Signed-off-by: Vinay Pepakayala <[email protected]>
vinay-852
force-pushed
the
vm-docs-update
branch
from
96bf959 to
39f9e77
Compare
kubevirt-bot
added
dco-signoff: yes
|
Hi @fabiand @victortoso, |
|
/cc @iholder101 |
|
|
||
| When the [VM rollout strategy](../user_workloads/vm_rollout_strategies.md) is set to `LiveUpdate`, changes to a VM's node selector, affinities, and tolerations will dynamically propagate to the VMI (unless the `RestartRequired` condition is set). | ||
|
|
||
| **Current behavior:** |
There was a problem hiding this comment.
Please remove this line. Everything in this document tries to explain the current behavior :)
| node selector or affinities will dynamically propagate to the VMI (unless the `RestartRequired` condition is set). | ||
| Changes to tolerations will not dynamically propagate, and will trigger a `RestartRequired` condition if changed on a | ||
| running VM. | ||
|
|
| - Changes to tolerations are now supported for live update and will be applied to the running VMI without requiring a restart, as long as the `RestartRequired` condition is not set. | ||
|
|
There was a problem hiding this comment.
I think we can remove this as it's already mentioned above.
| # | ||
| > **⚠️ Deprecation Notice:** | ||
| > | ||
| > The `spec.running` field is **deprecated** and should no longer be used to control VirtualMachine lifecycle. Use `spec.runStrategy` instead. Defining both `runStrategy` and `running` is **not allowed** and will be rejected by the API server. Always prefer `spec.runStrategy` for new and existing VirtualMachines. |
There was a problem hiding this comment.
That's nice, but IMO it would be better to simply document only run strategies below, then add a small section in the end explaining that there used to be a spec.running field, but that it's not recommended and should be avoided. WDYT?
4 participants
Resolves #923.