feat: run against higher order k8s kinds #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanz
requested changes
May 5, 2023
KhaledEmaraDev
force-pushed
the
higher-order-kinds
branch
from
fd7bd55 to
85a9f94
Compare
jvanz
requested changes
May 23, 2023
KhaledEmaraDev
force-pushed
the
higher-order-kinds
branch
from
85a9f94 to
5377ee6
Compare
viccuad
requested changes
May 25, 2023
There was a problem hiding this comment.
LGTM (some linter errors, also missing commiting artifacthub-pkg.yml to history)
Yet, is there a specific reason why we don't validate ephemeral containers? I cannot recall one, they have a securityContext, hence we can set capabilities for them (and an attacker can use it for privilege escalation). I suppose it's because the policy predates their inclusion and the analogous PSP didn't do it either for the same reason.
I would take that line from the readme (or add the reason if there's any), and open an issue to check for caps on ephemeral containers.
@KhaledEmaraDev, please, do it. |
KhaledEmaraDev
force-pushed
the
higher-order-kinds
branch
from
5377ee6 to
9f66fe8
Compare
KhaledEmaraDev
force-pushed
the
higher-order-kinds
branch
from
9f66fe8 to
9bd740c
Compare
Signed-off-by: Khaled Emara <[email protected]>
KhaledEmaraDev
force-pushed
the
higher-order-kinds
branch
from
9bd740c to
623fc37
Compare
jvanz
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #27
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement