Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh of language in Common tasks page #214

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

jhkrug
Copy link
Contributor

@jhkrug jhkrug commented Aug 22, 2023

and to reflect use of artifact hub instead of hub.kubewarden.io.

@jhkrug jhkrug added the area/documentation Improvements or additions to documentation label Aug 22, 2023
@jhkrug jhkrug requested a review from a team August 22, 2023 13:03
@jhkrug jhkrug self-assigned this Aug 22, 2023
@jhkrug jhkrug requested a review from a team as a code owner August 22, 2023 13:03
@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for silly-bunny-8cedd0 ready!

Name Link
🔨 Latest commit 84ec4d4
🔍 Latest deploy log https://app.netlify.com/sites/silly-bunny-8cedd0/deploys/64e4e4784d6b9e0008954a8b
😎 Deploy Preview https://deploy-preview-214--silly-bunny-8cedd0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jhkrug jhkrug linked an issue Aug 22, 2023 that may be closed by this pull request
@jhkrug jhkrug changed the title Refresh of language Refresh of language in Common tasks page Aug 22, 2023
@jhkrug jhkrug marked this pull request as draft August 22, 2023 13:05
@jhkrug
Copy link
Contributor Author

jhkrug commented Aug 22, 2023

There are a couple of TODO/FIXIT that I need to address in this.

Copy link
Member

@jvanz jvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have dropped some comments answering your questions about the text.

docs/tasks.md Outdated Show resolved Hide resolved
docs/tasks.md Outdated Show resolved Hide resolved
docs/tasks.md Outdated Show resolved Hide resolved
@jhkrug jhkrug marked this pull request as ready for review August 22, 2023 14:36
@jhkrug jhkrug requested a review from jvanz August 22, 2023 15:11
@jvanz jvanz merged commit c0cf65e into kubewarden:main Aug 23, 2023
6 checks passed
@jhkrug jhkrug deleted the common-tasks-page-refresh branch October 26, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Common tasks page updates
2 participants