Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make policy loop with io.kubewarden.policy.echo.loop annot #46

Closed
wants to merge 1 commit into from

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Jul 31, 2024

Description

Add a new Operation::Loop, that corresponds to
io.kubewarden.policy.echo.loop annotation.

When this annotation is present, the policy will loop indifinetly. This is helpful for testing purposes.

Test

Additional Information

Tradeoff

Potential improvement

Add a new `Operation::Loop`, that corresponds to
`io.kubewarden.policy.echo.loop` annotation.

When this annotation is present, the policy will loop indifinetly.
This is helpful for testing purposes.

Signed-off-by: Víctor Cuadrado Juan <[email protected]>
@viccuad viccuad self-assigned this Jul 31, 2024
@viccuad viccuad requested a review from a team as a code owner July 31, 2024 11:52
Copy link
Member

@jvanz jvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this feature be in the sleep policy instead?

@viccuad
Copy link
Member Author

viccuad commented Aug 1, 2024

Indeed, one can use the sleeping policy and doesn't need this policy 🤦 . Closing..

@viccuad viccuad closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants