Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Flavio Castelli <[email protected]>
  • Loading branch information
flavio and fabriziosestito authored Sep 20, 2024
1 parent b083d71 commit 516b045
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions charts/kubewarden-controller/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ maintainers:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 3.1.0-rc3
version: 3.0.0-rc3
# This is the version of Kubewarden stack
appVersion: v1.17.0-rc3
annotations:
Expand All @@ -35,14 +35,14 @@ annotations:
catalog.cattle.io/display-name: Kubewarden # Only for Charts with custom UI
catalog.cattle.io/os: linux # this means linux only, other choice here is "windows". For charts that support both, don't add this annotation
# optional ones:
catalog.cattle.io/auto-install: kubewarden-crds=1.10.0-rc3
catalog.cattle.io/auto-install: kubewarden-crds=1.9.0-rc3
catalog.cattle.io/provides-gvr: "policyservers.policies.kubewarden.io/v1" # Declare that this chart provides a type, which other charts may use in `requires-gvr`. Only add to parent, not CRD chart.
# The following two will create a UI warning if the request is not available in cluster
# Assume the most standard setup for your chart. These can be strings with amounts, ie 64Mi or 2Gi are both valid.
catalog.cattle.io/requests-cpu: "250m"
catalog.cattle.io/requests-memory: "50Mi"
catalog.cattle.io/rancher-version: ">= 2.6.0-0 <= 2.9.100-0" # Chart will only be available for users in the specified Rancher version(s), here its 2.5.0-2.5.99. This _must_ use build metadata or it won't work correctly for future RC's.
catalog.cattle.io/upstream-version: 3.1.0-rc3
catalog.cattle.io/upstream-version: 3.0.0-rc3
# Valid values for the following annotation include: `cluster-tool`, `app` or `cluster-template`
# See the Cluster Tools section to learn more about when to set this value to `cluster-tool`.
catalog.cattle.io/type: cluster-tool
Expand Down
4 changes: 2 additions & 2 deletions charts/kubewarden-crds/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ keywords:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.10.0-rc3
version: 1.9.0-rc3
# This is the version of Kubewarden stack
appVersion: v1.17.0-rc3
annotations:
Expand All @@ -33,7 +33,7 @@ annotations:
catalog.cattle.io/os: linux # this means linux only, other choice here is "windows". For charts that support both, don't add this annotation
# optional ones:
catalog.cattle.io/hidden: "true" # Hide specific charts. Only use on CRD charts.
catalog.cattle.io/upstream-version: 1.10.0-rc3
catalog.cattle.io/upstream-version: 1.9.0-rc3
# Valid values for the following annotation include: `cluster-tool`, `app` or `cluster-template`
# See the Cluster Tools section to learn more about when to set this value to `cluster-tool`.
catalog.cattle.io/type: cluster-tool
6 changes: 3 additions & 3 deletions charts/kubewarden-defaults/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ keywords:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.5.0-rc3
version: 2.4.0-rc3
# This is the version of Kubewarden stack
appVersion: v1.17.0-rc3
annotations:
Expand All @@ -35,8 +35,8 @@ annotations:
catalog.cattle.io/os: linux # this means linux only, other choice here is "windows". For charts that support both, don't add this annotation
# optional ones:
catalog.cattle.io/hidden: "true" # Hide specific charts. Only use on CRD charts.
catalog.cattle.io/upstream-version: 2.5.0-rc3
catalog.cattle.io/auto-install: kubewarden-crds=1.10.0-rc3
catalog.cattle.io/upstream-version: 2.4.0-rc3
catalog.cattle.io/auto-install: kubewarden-crds=1.9.0-rc3
# Valid values for the following annotation include: `cluster-tool`, `app` or `cluster-template`
# See the Cluster Tools section to learn more about when to set this value to `cluster-tool`.
catalog.cattle.io/type: cluster-tool

0 comments on commit 516b045

Please sign in to comment.