feat: Consume policy-server-root-ca Secret in auditScanner Cronjob #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done with a volumeMount. The `policy-server-root-ca` is created by the kubewarden-controller deployment, but only when there is a policy-server. This means that the first installation of kubearden-controller chart will deploy an audit-scanner cronjob that will continously fail, until there's a policy-server instantiated. This doesn't need to be this way, we can change the kubewarden-controller reconcile loop so it creates the ca secret without needing a policy-server first. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
|
e2e tests fail expectedly, as they aren't consuming the yet unmerged changes needed for audit-scanner. |
flavio
requested changes
Jul 28, 2023
There was a problem hiding this comment.
This mounts the contents of the entire secret into the Pod, that includes also the private key used by the CA, which is dangerous.
Please, project only the policy-server-root-ca.policy-server-root-ca-pem into the pod.
This describes how to do that.
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
|
Consumed the root-ca via the new |
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
|
Tested to be working with |
flavio
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial implementation of kubewarden/audit-scanner#64
Needs an audit-scanner image with kubewarden/audit-scanner#75
This is done with a volumeMount. The
policy-server-root-cais created by the kubewarden-controller deployment, but only when there is a policy-server. This means that the first installation of kubewarden-controller chart will deploy an audit-scanner cronjob that will continously fail, until there's a policy-server instantiated (normally when one installs the kubewarden-default chart).This doesn't need to be this way, we can change the kubewarden-controller reconcile loop so it creates the ca secret without needing a policy-server first.
Test
Tested locally, needs kubewarden/audit-scanner#75
Additional Information
Tradeoff
Potential improvement