Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart prerelease release #279

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 9, 2023

Automatic Helm chart prerelease update.
This PR has been created by the automation used to automatically update the Helm charts when some Kubewarden component is released

REMEMBER IF YOU WANT TO MERGE IN A SINGLE COMMIT CHANGES AND VERSION BUMP, YOU MUST SQUASH THE COMMIT BEFORE MERGING THIS PR!


Update Kubewarden chart versions

Update container image in the chart-values.yaml file

key "$.image.tag" updated from "v1.7.0-rc1" to "v1.7.0-rc2", in file "charts/kubewarden-controller/chart-values.yaml"

Update container image in the chart-values.yaml file

key "$.auditScanner.image.tag" updated from "\"v1.7.0-rc1\"" to "v1.7.0-rc2", in file "charts/kubewarden-controller/chart-values.yaml"

Bump controller chart app version

key "$.appVersion" updated from "v1.7.0-rc1" to "v1.7.0-rc2", in file "charts/kubewarden-controller/Chart.yaml"

Bump controller chart version

key "$.version" updated from "1.6.0-rc1" to "1.6.0-rc2", in file "charts/kubewarden-controller/Chart.yaml"

Bump defaults chart app version

key "$.appVersion" updated from "v1.7.0-rc1" to "v1.7.0-rc2", in file "charts/kubewarden-defaults/Chart.yaml"

Bump controller chart version in annotations

key "$.annotations.'catalog.cattle.io/upstream-version'" updated from "1.6.0-rc1" to "1.6.0-rc2", in file "charts/kubewarden-controller/Chart.yaml"

Bump defaults chart version in annotations

key "$.annotations.'catalog.cattle.io/upstream-version'" updated from "1.7.0-rc1" to "1.7.0-rc2", in file "charts/kubewarden-defaults/Chart.yaml"

Update container image in the chart-values.yaml file

key "$.policyServer.image.tag" updated from "v1.7.0-rc1" to "v1.7.0-rc2", in file "charts/kubewarden-defaults/chart-values.yaml"

Update container image in the values.yaml file

key "$.policyServer.image.tag" updated from "v1.7.0-rc1" to "v1.7.0-rc2", in file "charts/kubewarden-defaults/values.yaml"

Bump defaults chart version

key "$.version" updated from "1.7.0-rc1" to "1.7.0-rc2", in file "charts/kubewarden-defaults/Chart.yaml"

Update container image in the values.yaml file

key "$.auditScanner.image.tag" updated from "\"v1.7.0-rc1\"" to "v1.7.0-rc2", in file "charts/kubewarden-controller/values.yaml"

Update container image in the values.yaml file

key "$.image.tag" updated from "v1.7.0-rc1" to "v1.7.0-rc2", in file "charts/kubewarden-controller/values.yaml"


Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

@github-actions github-actions bot requested a review from a team as a code owner August 9, 2023 17:07
@github-actions github-actions bot added the kind/enhancement New feature or request label Aug 9, 2023
Copy link
Member

@jvanz jvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -40,7 +40,7 @@ annotations:
catalog.cattle.io/requests-cpu: "250m"
Copy link
Member

@viccuad viccuad Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(opening thread here because GH doesn't allow on line 36)

Being pedantic, the kubewarden-crds chart version and appVersion should have been bumped, and then both kubewarden-controller and kubewarden-defaults should have catalog.cattle.io/auto-install: kubewarden-crds=1.4.0-rc2.

I will add a commit with that.

Right now this is no problem, and maybe it wasn't triggered because there wasn't any change to kubewaden-crds content. But if there are future changes, it should trigger.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right. Let's fix that manually on this PR and track that with a dedicated issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with followup commits.

@viccuad viccuad requested a review from flavio August 10, 2023 06:48
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
@viccuad
Copy link
Member

viccuad commented Aug 10, 2023

Commit bd85511, that only adds whitespace, was needed, as it seems we aren't calling make generate-values on the updatecli automation?

It also makes me wonder, CI didn't run for the bot commits, but it did for mine, why?

Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes!

@flavio
Copy link
Member

flavio commented Aug 10, 2023

It also makes me wonder, CI didn't run for the bot commits, but it did for mine, why?

That's strange, are you sure the jobs didn't run or have they been canceled by us?

@viccuad
Copy link
Member

viccuad commented Aug 10, 2023

That's strange, are you sure the jobs didn't run or have they been canceled by us?

On the commit list, I see no tick for the commits from chimera-kube-bot, nor I see a run listed on https://github.com/kubewarden/helm-charts/actions/workflows/ci.yaml for this PR.

@flavio flavio merged commit 5c0c888 into main Aug 10, 2023
4 of 6 checks passed
@flavio flavio deleted the updatecli_3bdd7ed176b7c7e43e62572cc23811005f1f7ad987895cb2cc3474ce8ff04f3b branch August 10, 2023 07:08
jvanz pushed a commit that referenced this pull request Aug 30, 2023
feat: Update Kubewarden Helm charts

Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Co-authored-by: Kubewarden bot <[email protected]>
Co-authored-by: Víctor Cuadrado Juan <[email protected]>
jvanz pushed a commit to jvanz/helm-charts that referenced this pull request Sep 5, 2023
feat: Update Kubewarden Helm charts

Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Co-authored-by: Kubewarden bot <[email protected]>
Co-authored-by: Víctor Cuadrado Juan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants