Policy group files #518
Merged
Policy group files #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the kubewarden-crds Helm chart to install the new policy types. The ClusterAdmissionPolicyGroup and AdmissionPolicyGroup. Signed-off-by: José Guilherme Vanz <[email protected]>
Updates the RBAC roles used by the controller to include the new policy group types. Therefore, the controller will be able to start watching the new policies types. Signed-off-by: José Guilherme Vanz <[email protected]>
Updates the webhooks configuration used be the controller to validate CRDs. The webhooks now include the new policy group types. Signed-off-by: José Guilherme Vanz <[email protected]>
|
Moving to blocked, we have to wait for kubewarden/kubewarden-controller#872 to be fixed, then copy the correct CRDs definitions into this PR |
flavio
requested changes
Sep 9, 2024
There was a problem hiding this comment.
Waiting for kubewarden/kubewarden-controller#872 to be solved
fabriziosestito
approved these changes
Sep 9, 2024
viccuad
approved these changes
Sep 9, 2024
|
We have decided to merge this to unblock the E2E tests. Once we have kubewarden/kubewarden-controller#872, we will bump the Helm charts with the CRDs accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Helm charts to have the files required by the controller to be able to reconcile policy group types.
Fix kubewarden/kubewarden-controller#857