fix: set default value for old CA field when missing. #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
requested changes
Sep 11, 2024
| @@ -14,6 +14,14 @@ | |||
| {{ $caCert = (index $caSecret.data "ca.crt") }} | |||
| {{ $caPrivateKey = (index $caSecret.data "ca.key") }} | |||
| {{ $oldCaCert = (index $caSecret.data "old-ca.crt") }} | |||
| # Check if the old CA certificate is missing. If so, set it to "". This is to | |||
There was a problem hiding this comment.
a simpler alternative : {{ $oldCaCert = (index $caSecret.data "old-ca.crt" | default "") }}
Updates the webhooks.yaml template to set a default value "" to the old CA certificate when it's missing. This can happen because the empty value in the secret is removed during the upgrade. Therefore, in a future upgrade the b64enc function fails because the value is nil. Signed-off-by: José Guilherme Vanz <[email protected]>
fabriziosestito
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the webhooks.yaml template to set a default value "" to the old CA certificate when it's missing. This can happen because the empty value in the secret is removed during the upgrade. Therefore, in a future upgrade the b64enc function fails because the value is nil.
Fix #523