Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add kubewarden-controller webhooks unit test #531

Merged
merged 2 commits into from
Sep 18, 2024
Merged

test: add kubewarden-controller webhooks unit test #531

merged 2 commits into from
Sep 18, 2024

Conversation

fabriziosestito
Copy link
Contributor

@fabriziosestito fabriziosestito commented Sep 12, 2024 •
edited
Loading

Description

Fixes: #516 #507

@fabriziosestito fabriziosestito self-assigned this Sep 12, 2024
flavio
flavio reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this testing approach, I think we can move forward with it.

Thanks a lot for having looked into this topic!

charts/kubewarden-controller/tests/webhooks_existing_certifcates_test.yaml Outdated Show resolved Hide resolved
charts/kubewarden-controller/tests/webhooks_existing_certifcates_test.yaml Outdated Show resolved Hide resolved
charts/kubewarden-controller/tests/webhooks_existing_certifcates_test.yaml Show resolved Hide resolved
jvanz
jvanz approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@jvanz jvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I module the Flavio's comments. Besides that, I'm happy to move forward with the test plugin. :)

@fabriziosestito fabriziosestito force-pushed the test/kubewarden-controller-webhooks-unit-test branch 3 times, most recently from 802553a to e94affd Compare September 18, 2024 06:37
@fabriziosestito fabriziosestito marked this pull request as ready for review September 18, 2024 06:50
@fabriziosestito fabriziosestito requested a review from a team as a code owner September 18, 2024 06:50
flavio
flavio approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@fabriziosestito
ci: add test job
14b546f 
Signed-off-by: Fabrizio Sestito <[email protected]>
@fabriziosestito fabriziosestito force-pushed the test/kubewarden-controller-webhooks-unit-test branch from e94affd to 14b546f Compare September 18, 2024 08:32
@fabriziosestito fabriziosestito merged commit 63d47e5 into kubewarden:main Sep 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavio flavio flavio approved these changes

@jvanz jvanz Awaiting requested review from jvanz

Assignees

@fabriziosestito fabriziosestito

Labels
area/ci
Projects
Kubewarden
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing: add controller webhooks unit test
3 participants
@fabriziosestito @flavio @jvanz