-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update all minor level dependencies #1007
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
===========================================
- Coverage 72.66% 59.35% -13.32%
===========================================
Files 30 17 -13
Lines 3750 1545 -2205
===========================================
- Hits 2725 917 -1808
+ Misses 867 617 -250
+ Partials 158 11 -147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
327f70e
to
a513541
Compare
ed9acb9
to
ea3ffa3
Compare
This needs some attention, the linter is failing inside of GHA but it's fine locally 🤷 |
To see the errors from the CI it was necessary to update the go lang and the golang linter version in use to the version with golang 1.24 support. I've updated the PR to fix all the errors and bumps the version in the CI files and Makefile . |
Use go version 1.24 in the CI to run the linter. This will sync the go version in CI, Dockerfile and go.mod files. Signed-off-by: José Guilherme Vanz <[email protected]>
Updates the golang-linter version to 1.64.5 to support go lang 1.24. Signed-off-by: José Guilherme Vanz <[email protected]>
Fixes all the errors reported by the latest golang linter in use. Signed-off-by: José Guilherme Vanz <[email protected]>
395b3e1
to
b6dde87
Compare
The CI of this PR is failing due to this problem: kubewarden/policy-server#1096 |
b6dde87
to
93cc293
Compare
93cc293
to
b6dde87
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
@@ -234,7 +234,6 @@ linters: | |||
- errname # checks that sentinel errors are prefixed with the Err and error types are suffixed with the Error | |||
- errorlint # finds code that will cause problems with the error wrapping scheme introduced in Go 1.13 | |||
- exhaustive # checks exhaustiveness of enum switch statements | |||
- exportloopref # checks for pointers to enclosing loop variables | |||
- fatcontext # detects nested contexts in loops |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linters seem outdated. Should we update our config to match the new v1.64.5 version from https://gist.github.com/maratori/47a4d00457a92aa426dbd48a18776322, but keep our custom settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree. I did remove the linter for cel-policy on kubewarden/cel-policy#116
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I added a note about the golangci config, but we can fix that in another PR or issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR contains the following updates:
1.23.6
->1.24.0
1.23
->1.24
v6.3.2
->v6.5.0
Release Notes
golang/go (go)
v1.24.0
golangci/golangci-lint-action (golangci/golangci-lint-action)
v6.5.0
Compare Source
What's Changed
Changes
Dependencies
Full Changelog: golangci/golangci-lint-action@v6.4.1...v6.5.0
v6.4.1
Compare Source
What's Changed
Changes
Full Changelog: golangci/golangci-lint-action@v6.4.0...v6.4.1
v6.4.0
Compare Source
What's Changed
Changes
Full Changelog: golangci/golangci-lint-action@v6.3.3...v6.4.0
v6.3.3
Compare Source
What's Changed
Changes
Full Changelog: golangci/golangci-lint-action@v6.3.2...v6.3.3
Configuration
📅 Schedule: Branch creation - "* 0-4,22-23 * * 1-5,* * * * 0,6" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.