Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update all minor level dependencies #1007

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 12, 2025

This PR contains the following updates:

Package Type Update Change
go (source) toolchain minor 1.23.6 -> 1.24.0
golang stage minor 1.23 -> 1.24
golangci/golangci-lint-action action minor v6.3.2 -> v6.5.0

Release Notes

golang/go (go)

v1.24.0

golangci/golangci-lint-action (golangci/golangci-lint-action)

v6.5.0

Compare Source

What's Changed

Changes
Dependencies

Full Changelog: golangci/golangci-lint-action@v6.4.1...v6.5.0

v6.4.1

Compare Source

What's Changed

Changes

Full Changelog: golangci/golangci-lint-action@v6.4.0...v6.4.1

v6.4.0

Compare Source

What's Changed

Changes

Full Changelog: golangci/golangci-lint-action@v6.3.3...v6.4.0

v6.3.3

Compare Source

What's Changed

Changes

Full Changelog: golangci/golangci-lint-action@v6.3.2...v6.3.3


Configuration

📅 Schedule: Branch creation - "* 0-4,22-23 * * 1-5,* * * * 0,6" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner February 12, 2025 01:28
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.35%. Comparing base (2cd74d8) to head (93cc293).

❗ There is a different number of reports uploaded between BASE (2cd74d8) and HEAD (93cc293). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (2cd74d8) HEAD (93cc293)
integration-tests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1007       +/-   ##
===========================================
- Coverage   72.66%   59.35%   -13.32%     
===========================================
  Files          30       17       -13     
  Lines        3750     1545     -2205     
===========================================
- Hits         2725      917     -1808     
+ Misses        867      617      -250     
+ Partials      158       11      -147     
Flag Coverage Δ
integration-tests ?
unit-tests 59.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title build(deps): update dependency go to v1.24.0 build(deps): update all minor level dependencies Feb 12, 2025
@renovate renovate bot force-pushed the renovate/all-minor branch 2 times, most recently from 327f70e to a513541 Compare February 13, 2025 12:10
@jvanz jvanz self-assigned this Feb 13, 2025
@jvanz jvanz force-pushed the renovate/all-minor branch from ed9acb9 to ea3ffa3 Compare February 13, 2025 17:09
@jvanz jvanz removed their assignment Feb 14, 2025
@flavio
Copy link
Member

flavio commented Feb 14, 2025

This needs some attention, the linter is failing inside of GHA but it's fine locally 🤷

@jvanz jvanz self-assigned this Feb 17, 2025
@jvanz
Copy link
Member

jvanz commented Feb 17, 2025

To see the errors from the CI it was necessary to update the go lang and the golang linter version in use to the version with golang 1.24 support. I've updated the PR to fix all the errors and bumps the version in the CI files and Makefile .

renovate bot and others added 4 commits February 17, 2025 18:30
Use go version 1.24 in the CI to run the linter. This will sync the go
version in CI, Dockerfile and go.mod files.

Signed-off-by: José Guilherme Vanz <[email protected]>
Updates the golang-linter version to 1.64.5 to support go lang 1.24.

Signed-off-by: José Guilherme Vanz <[email protected]>
Fixes all the errors reported by the latest golang linter in use.

Signed-off-by: José Guilherme Vanz <[email protected]>
@jvanz jvanz force-pushed the renovate/all-minor branch from 395b3e1 to b6dde87 Compare February 17, 2025 21:33
@jvanz jvanz added this to the 1.22 milestone Feb 18, 2025
@jvanz
Copy link
Member

jvanz commented Feb 18, 2025

The CI of this PR is failing due to this problem: kubewarden/policy-server#1096

Copy link
Contributor Author

renovate bot commented Feb 18, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@@ -234,7 +234,6 @@ linters:
- errname # checks that sentinel errors are prefixed with the Err and error types are suffixed with the Error
- errorlint # finds code that will cause problems with the error wrapping scheme introduced in Go 1.13
- exhaustive # checks exhaustiveness of enum switch statements
- exportloopref # checks for pointers to enclosing loop variables
- fatcontext # detects nested contexts in loops
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linters seem outdated. Should we update our config to match the new v1.64.5 version from https://gist.github.com/maratori/47a4d00457a92aa426dbd48a18776322, but keep our custom settings?

Copy link
Member

@viccuad viccuad Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree. I did remove the linter for cel-policy on kubewarden/cel-policy#116

Copy link
Contributor

@fabriziosestito fabriziosestito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added a note about the golangci config, but we can fix that in another PR or issue.

Copy link
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvanz jvanz merged commit 2e36964 into main Feb 19, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants