Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tiltfile): remove overriding helm webhooks with kustomize ones #867

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

fabriziosestito
Copy link
Contributor

Description

Recently we changed the Tiltfile to override the Helm chart's webhooks with the ones provided by the Kustomize folder.
However, this breaks since we now inject initial certificate bundles from the helm chart.
While having the scaffolded webhooks updated automatically can be handy, we don't expect adding webhooks frequently to justify the added complexity of merging the two configurations.

This PR fixes: #854 by removing the Kustomize webhooks logic in the tiltfile

@fabriziosestito fabriziosestito requested a review from a team as a code owner September 2, 2024 14:45
@fabriziosestito fabriziosestito self-assigned this Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.18%. Comparing base (3b49c48) to head (01db755).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #867   +/-   ##
=======================================
  Coverage   70.18%   70.18%           
=======================================
  Files          29       29           
  Lines        2603     2603           
=======================================
  Hits         1827     1827           
  Misses        600      600           
  Partials      176      176           
Flag Coverage Δ
integration-tests 61.10% <ø> (ø)
unit-tests 35.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flavio
Copy link
Member

flavio commented Sep 3, 2024

Maybe I'm wrong, but that would cause the validating/mutating webhooks defined by controller to not be used in development mode because they would not be registered. Am I right?

@fabriziosestito
Copy link
Contributor Author

Maybe I'm wrong, but that would cause the validating/mutating webhooks defined by controller to not be used in development mode because they would not be registered. Am I right?

@flavio they will be configured by the helm chart installed by the tiltfile

Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavio flavio requested a review from jvanz September 3, 2024 13:05
@jvanz jvanz merged commit 810f26e into kubewarden:main Sep 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

tilt: webhooks should have the certificates set
3 participants