feat: multiple client CA. #1090
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
===========================================
- Coverage 63.69% 36.49% -27.20%
===========================================
Files 17 16 -1
Lines 1179 1148 -31
===========================================
- Hits 751 419 -332
- Misses 428 729 +301
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| let config = build_tls_server_config(&tls_config).await?; | ||
|
|
||
| let rust_config = RustlsConfig::from_config(Arc::new(config)); | ||
| // Build initial TLS configuration |
There was a problem hiding this comment.
I know that the issue asked to refactor this code to improve readability. But during my tests, I though that the code ended to be worst not better. If you have some idea how to improve this code. Please, let me know. I would be happy to apply your suggestions
There was a problem hiding this comment.
I thin it is fine for the scope of this PR, I noticed a few things we could improve though - I started working on these in #1091 which will also help clean up this function.
Updates the policy server to allow loading multiple CA to validate the certificate used by client in a mTLS scenario. Signed-off-by: José Guilherme Vanz <[email protected]>
|
@kubewarden/kubewarden-developers I see the integration tests failing. But they are not failing locally. Anyway, I'm working on this. |
Description
Updates the policy server to allow loading multiple CA to validate the certificate used by client in a mTLS scenario.
Fix #1078
Test
make test