fix(test): concurrent access to global OTEL configuration. #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1097 +/- ##
==========================================
+ Coverage 57.52% 60.63% +3.11%
==========================================
Files 18 18
Lines 1189 1189
==========================================
+ Hits 684 721 +37
+ Misses 505 468 -37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvanz
force-pushed
the
fix-otel
branch
6 times, most recently
from
3940a2e to
a1058c5
Compare
jvanz
changed the title
jvanz
force-pushed
the
fix-otel
branch
3 times, most recently
from
acff66f to
a51beff
Compare
jvanz
commented
Feb 25, 2025
Comment on lines
+65
to
+66
| - name: Run integration-tests coverage | ||
| run: make integration-tests |
There was a problem hiding this comment.
I've also took this opportunity to remove the deprecated actions-rc/cargo action.
The OTEL test is flaky because it relies on the global OTEL configuration that can be overwrite by other concurrent tests. Therefore, the OTEL test now is behind a feature gate to ensure that it will be run on isolation. Signed-off-by: José Guilherme Vanz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The OTEL test is flaky because it relies on the global OTEL configuration that can be overwrite by other concurrent tests.
Therefore, the OTEL test now is behind a feature gate to ensure that it will be run on isolation.
Fix #916