docs: update nodescan rfc#1207
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Node Scan RFC to reflect the latest NodeScanConfiguration/NodeScanJob workflow and lifecycle semantics requested in #1206, clarifying how periodic vs. immediate scans are triggered and how resources are garbage-collected.
Changes:
- Makes
scanIntervalexplicitly mandatory and framesNodeScanConfigurationas the periodic scan scheduler. - Documents an immediate-scan trigger via
force-node-scan: "true"annotation with automatic removal after completion. - Updates the RFC to reflect inverted ownership/GC semantics:
NodeScanConfigurationowns jobs/SBOMs (Kubernetes GC), while node deletion requires controller-driven cleanup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
- Coverage 53.44% 52.78% -0.67%
==========================================
Files 61 77 +16
Lines 5340 6472 +1132
==========================================
+ Hits 2854 3416 +562
- Misses 2088 2582 +494
- Partials 398 474 +76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9c7a1d5 to
1dc4a76
Compare
Signed-off-by: Alessio Greggi <alessio.greggi@suse.com>
1dc4a76 to
015cec9
Compare
|
|
fabriziosestito
left a comment
There was a problem hiding this comment.
Please address the missing comment
|
@alegrey91, I'm merging this. The comment in #1207 (comment) is still unresolved, but I'll address it during a second pass on the RFC. |
Description
Fix #1206
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement
Checklist