Skip to content

docs: update nodescan rfc#1207

Merged
fabriziosestito merged 3 commits into
kubewarden:mainfrom
alegrey91:docs/update-nodescan-rfc
Jul 1, 2026
Merged

docs: update nodescan rfc#1207
fabriziosestito merged 3 commits into
kubewarden:mainfrom
alegrey91:docs/update-nodescan-rfc

Conversation

@alegrey91

@alegrey91 alegrey91 commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Description

Fix #1206

Test

To test this pull request, you can run the following commands:

Additional Information

Tradeoff

Potential improvement

Checklist

Copilot AI review requested due to automatic review settings June 4, 2026 12:36
@alegrey91 alegrey91 requested a review from a team as a code owner June 4, 2026 12:36
@github-project-automation github-project-automation Bot moved this to Pending Review in SBOMscanner Jun 4, 2026
@alegrey91 alegrey91 self-assigned this Jun 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Node Scan RFC to reflect the latest NodeScanConfiguration/NodeScanJob workflow and lifecycle semantics requested in #1206, clarifying how periodic vs. immediate scans are triggered and how resources are garbage-collected.

Changes:

  • Makes scanInterval explicitly mandatory and frames NodeScanConfiguration as the periodic scan scheduler.
  • Documents an immediate-scan trigger via force-node-scan: "true" annotation with automatic removal after completion.
  • Updates the RFC to reflect inverted ownership/GC semantics: NodeScanConfiguration owns jobs/SBOMs (Kubernetes GC), while node deletion requires controller-driven cleanup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/rfc/0008_node_scan.md Outdated
Comment thread docs/rfc/0008_node_scan.md Outdated
Comment thread docs/rfc/0008_node_scan.md Outdated
Comment thread docs/rfc/0008_node_scan.md Outdated
@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.78%. Comparing base (5adb1bd) to head (b61805c).
⚠️ Report is 113 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1207      +/-   ##
==========================================
- Coverage   53.44%   52.78%   -0.67%     
==========================================
  Files          61       77      +16     
  Lines        5340     6472    +1132     
==========================================
+ Hits         2854     3416     +562     
- Misses       2088     2582     +494     
- Partials      398      474      +76     
Flag Coverage Δ
unit-tests 52.78% <ø> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabriziosestito fabriziosestito moved this from Pending Review to In Progress in SBOMscanner Jun 15, 2026
@alegrey91 alegrey91 force-pushed the docs/update-nodescan-rfc branch from 9c7a1d5 to 1dc4a76 Compare June 16, 2026 09:12
Signed-off-by: Alessio Greggi <alessio.greggi@suse.com>
@alegrey91 alegrey91 force-pushed the docs/update-nodescan-rfc branch from 1dc4a76 to 015cec9 Compare June 16, 2026 09:14
@flavio

flavio commented Jun 17, 2026

Copy link
Copy Markdown
Member

@alegrey91 WARNING: you will probably have to close this PR and open it against the kubewarden/docs this is a change to the RFC, hence it's fine to do it here

@alegrey91 alegrey91 moved this from In Progress to Pending Review in SBOMscanner Jun 19, 2026
Comment thread docs/rfc/0008_node_scan.md Outdated
Comment thread docs/rfc/0008_node_scan.md Outdated
Comment thread docs/rfc/0008_node_scan.md Outdated
@fabriziosestito fabriziosestito added the documentation Improvements or additions to documentation label Jun 26, 2026
@fabriziosestito fabriziosestito added this to the v0.12.0 milestone Jun 26, 2026
Signed-off-by: Alessio Greggi <alessio.greggi@suse.com>

@fabriziosestito fabriziosestito left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the missing comment

Signed-off-by: Alessio Greggi <alessio.greggi@suse.com>
@alegrey91 alegrey91 requested a review from fabriziosestito July 1, 2026 09:06
@fabriziosestito fabriziosestito merged commit 5850085 into kubewarden:main Jul 1, 2026
12 of 13 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Review to Done in SBOMscanner Jul 1, 2026
@fabriziosestito

Copy link
Copy Markdown
Collaborator

@alegrey91, I'm merging this. The comment in #1207 (comment) is still unresolved, but I'll address it during a second pass on the RFC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

update rfc with most recent updates

4 participants