docs: update nodescan rfc#1269
Merged
fabriziosestito merged 10 commits intoJul 3, 2026
Merged
Conversation
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
…ng notes Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
fabriziosestito
added
the
documentation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the NodeScan RFC documentation to better describe configuration behavior and operational drawbacks, aligning the spec text with current NodeScan CRD options and runtime expectations.
Changes:
- Expands the “immediate rescan” annotation behavior description.
- Documents
NodeScanConfiguration.spec.enabledand the defaultskipPatternsbehavior (including how to disable defaults). - Adds additional drawbacks around required Linux capability and the always-running DaemonSet model.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1269 +/- ##
==========================================
- Coverage 52.85% 52.73% -0.13%
==========================================
Files 77 77
Lines 6472 6472
==========================================
- Hits 3421 3413 -8
- Misses 2576 2582 +6
- Partials 475 477 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
fabriziosestito
force-pushed
the
docs/update-nodescan-rfc
branch
from
abaca57 to
dc820e7
Compare
…ine PSA Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
…work Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
flavio
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Enable/Disable, skipPatterns defaults and drawbacks