feat: mutate all types of resources #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `default_features` key is deprecated, it will be removed from future versions of rust. Switch to `default-features` instead. Signed-off-by: Flavio Castelli <[email protected]>
jvanz
approved these changes
Sep 6, 2024
Allow the policy to mutate not only Pods, but also Deployments, ReplicaSets, DaemonSets,... While doing that I also refactored the code, removing some repetition and I cleaned up the unit tests. Signed-off-by: Flavio Castelli <[email protected]>
Use latest version of our GH actions Signed-off-by: Flavio Castelli <[email protected]>
flavio
force-pushed
the
mutate-everything
branch
from
a9b04ae to
24c3073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the policy to mutate not only Pods, but also Deployments, ReplicaSets, DaemonSets,...
While doing that I also refactored the code, removing some repetition and I cleaned up the unit tests.
Note: I would also like to split the contents of
lib.rsinto smaller files, but I don't know if this is something to be done with this PR or with another one.