Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Example of rules for workload resources in Readme #90

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Jan 18, 2024

Description

Relates to kubewarden/kubewarden-controller#611

Fix rules example in readme for all workload resources. We instruct users to use the example in the readme for all workload resources. metadata.yml only targets pods and is unchanged.

Test

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Víctor Cuadrado Juan <[email protected]>
@viccuad viccuad self-assigned this Jan 18, 2024
@viccuad viccuad requested a review from a team as a code owner January 18, 2024 09:48
@viccuad viccuad changed the title Fix: rules example in Readme fix: Example of rules for workload resources in Readme Jan 18, 2024
Co-authored-by: Martin Kravec <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, ship it!

@jvanz jvanz merged commit d80e4ee into kubewarden:main Jan 18, 2024
@viccuad
Copy link
Member Author

viccuad commented Jan 19, 2024

Released as 0.2.9.

@viccuad viccuad deleted the fix-rules branch March 21, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants