Skip to content

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng force-pushed the dev/support-numa-l3-cache-cpu-map branch from b167471 to 42a41b2 Compare September 3, 2025 07:37
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 92.89100% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.57%. Comparing base (546736a) to head (17250e6).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/machine/topology.go 94.07% 6 Missing and 2 partials ⚠️
...ins/cpu/dynamicpolicy/calculator/cpu_assignment.go 90.54% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
+ Coverage   58.40%   58.57%   +0.16%     
==========================================
  Files         670      670              
  Lines       75919    76097     +178     
==========================================
+ Hits        44342    44572     +230     
+ Misses      27286    27236      -50     
+ Partials     4291     4289       -2     
Flag Coverage Δ
unittest 58.57% <92.89%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@luomingmeng luomingmeng force-pushed the dev/support-numa-l3-cache-cpu-map branch 4 times, most recently from 460d5d8 to 88975c5 Compare September 4, 2025 09:34
introduce L3 cache topology mapping to track relationships between L3 caches, CPUs and NUMA nodes
add new L3CacheTopology struct and related query methods
extend CPUInfo with L3CacheID field and update topology builders
add comprehensive tests for L3 cache topology functionality
…ache alignment

Add L3 cache topology awareness to CPU allocation strategy to improve cache locality. The new algorithm:
1. Adds L3 cache topology information to CPUDetails
2. Implements L3 cache-aware sorting and allocation logic
3. Makes L3 cache alignment optional via parameter
4. Improves error messages and logging for debugging
Move the UnknownNumaNode constant from network_linux.go to network.go to make it available across all platforms and avoid duplication
@luomingmeng luomingmeng force-pushed the dev/support-numa-l3-cache-cpu-map branch from 88975c5 to 17250e6 Compare September 4, 2025 10:32
@luomingmeng luomingmeng added the workflow/need-review review: test succeeded, need to review label Sep 8, 2025
@luomingmeng luomingmeng self-assigned this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant