-
Notifications
You must be signed in to change notification settings - Fork 137
feat(state): allow storing of state in tmpfs instead of disk #961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JustinChengLZ
wants to merge
12
commits into
kubewharf:main
Choose a base branch
from
JustinChengLZ:dev/tmpfs-state-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(state): allow storing of state in tmpfs instead of disk #961
JustinChengLZ
wants to merge
12
commits into
kubewharf:main
from
JustinChengLZ:dev/tmpfs-state-migration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c5b442
to
fbda737
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
==========================================
+ Coverage 58.61% 58.68% +0.07%
==========================================
Files 678 680 +2
Lines 76623 76939 +316
==========================================
+ Hits 44909 45151 +242
- Misses 27385 27433 +48
- Partials 4329 4355 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
82167ca
to
bafbde4
Compare
8879d87
to
a29aa69
Compare
fix: modify flags
fix: bug in storing state
fix: tests chore: format
feat: unit tests chore: debug fix: bug fix: breaking unit tests chore: lint
feat: remove old checkpoint file feat: remove old checkpoint file revert: sysadvisor changes feat: refactor chore: format fix: build errors chore: format fix: build errors fix: unit tests # Conflicts: # pkg/agent/qrm-plugins/cpu/dynamicpolicy/hintoptimizer/policy/memorybandwidth/optimizer_test.go
feat: implement pre-stop support and checkpoint fallback feat: implement pre-stop support and checkpoint fallback feat: implement pre-stop support and checkpoint fallback feat: implement pre-stop support and checkpoint fallback
feat: clean up test cases and improve code coverage feat: clean up test cases and improve code coverage feat: clean up test cases and improve code coverage feat: clean up test cases and improve code coverage feat: clean up test cases and improve code coverage
feat: refactor logic into new file feat: refactor logic into new file
902b9cb
to
7e5e442
Compare
fix: issue with error not propagating properly fix: issue with error not propagating properly fix: issue with error not propagating properly chore: goimport chore: goimport
7e5e442
to
3caa357
Compare
1fa3948
to
e5cb966
Compare
feat: implement time check to check if state files are up to date feat: implement time check to check if state files are up to date feat: implement time check to check if state files are up to date
e5cb966
to
b8ad643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Some machines have bad disk performance so we can provide the option to store in memory (tmpfs). We need to ensure that when we want to store state in memory, we migrate the old state file from disk to memory.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: