Skip to content

Conversation

JustinChengLZ
Copy link
Collaborator

What type of PR is this?

Some machines have bad disk performance so we can provide the option to store in memory (tmpfs). We need to ensure that when we want to store state in memory, we migrate the old state file from disk to memory.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 67.21763% with 119 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.68%. Comparing base (221a24d) to head (b8ad643).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ins/memory/dynamicpolicy/state/state_checkpoint.go 56.25% 22 Missing and 6 partials ⚠️
.../util/qrmcheckpointmanager/qrmcheckpointmanager.go 74.03% 18 Missing and 9 partials ⚠️
...gent/qrm-plugins/network/state/state_checkpoint.go 60.31% 19 Missing and 6 partials ⚠️
...lugins/cpu/dynamicpolicy/state/state_checkpoint.go 59.32% 19 Missing and 5 partials ⚠️
.../options/qrm/statedirectory/statedirectory_base.go 52.38% 10 Missing ⚠️
cmd/katalyst-agent/app/options/qrm/qrm_base.go 20.00% 3 Missing and 1 partial ⚠️
pkg/agent/qrm-plugins/cpu/nativepolicy/policy.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
+ Coverage   58.61%   58.68%   +0.07%     
==========================================
  Files         678      680       +2     
  Lines       76623    76939     +316     
==========================================
+ Hits        44909    45151     +242     
- Misses      27385    27433      +48     
- Partials     4329     4355      +26     
Flag Coverage Δ
unittest 58.68% <67.21%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JustinChengLZ JustinChengLZ force-pushed the dev/tmpfs-state-migration branch 6 times, most recently from 82167ca to bafbde4 Compare September 11, 2025 06:11
@JustinChengLZ JustinChengLZ force-pushed the dev/tmpfs-state-migration branch 13 times, most recently from 8879d87 to a29aa69 Compare September 17, 2025 08:17
fix: bug in storing state
fix: tests

chore: format
feat: unit tests

chore: debug

fix: bug

fix: breaking unit tests

chore: lint
feat: remove old checkpoint file

feat: remove old checkpoint file

revert: sysadvisor changes

feat: refactor

chore: format

fix: build errors

chore: format

fix: build errors

fix: unit tests

# Conflicts:
#	pkg/agent/qrm-plugins/cpu/dynamicpolicy/hintoptimizer/policy/memorybandwidth/optimizer_test.go
feat: implement pre-stop support and checkpoint fallback

feat: implement pre-stop support and checkpoint fallback

feat: implement pre-stop support and checkpoint fallback

feat: implement pre-stop support and checkpoint fallback
feat: clean up test cases and improve code coverage

feat: clean up test cases and improve code coverage

feat: clean up test cases and improve code coverage

feat: clean up test cases and improve code coverage

feat: clean up test cases and improve code coverage
feat: refactor logic into new file

feat: refactor logic into new file
@JustinChengLZ JustinChengLZ force-pushed the dev/tmpfs-state-migration branch 4 times, most recently from 902b9cb to 7e5e442 Compare September 22, 2025 03:30
fix: issue with error not propagating properly

fix: issue with error not propagating properly

fix: issue with error not propagating properly

chore: goimport

chore: goimport
@JustinChengLZ JustinChengLZ force-pushed the dev/tmpfs-state-migration branch from 7e5e442 to 3caa357 Compare September 22, 2025 03:46
@JustinChengLZ JustinChengLZ added the workflow/need-review review: test succeeded, need to review label Sep 23, 2025
@JustinChengLZ JustinChengLZ force-pushed the dev/tmpfs-state-migration branch 2 times, most recently from 1fa3948 to e5cb966 Compare September 24, 2025 07:57
@JustinChengLZ JustinChengLZ changed the title [WIP] feat(state): allow storing of state in tmpfs instead of disk feat(state): allow storing of state in tmpfs instead of disk Sep 24, 2025
feat: implement time check to check if state files are up to date

feat: implement time check to check if state files are up to date

feat: implement time check to check if state files are up to date
@JustinChengLZ JustinChengLZ force-pushed the dev/tmpfs-state-migration branch from e5cb966 to b8ad643 Compare September 24, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant