ci: add github actions workflow to run go tests #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests did not compile, so I also did the minimal amount of changes to get them compiling and passing.
``` + cd /home/runner/work/_temp/go/pkg/mod/sigs.k8s.io/controller-runtime/tools/[email protected] + GOBIN=/home/runner/work/kubezoo/kubezoo/bin go install ./ go: errors parsing go.mod: /home/runner/work/_temp/go/pkg/mod/sigs.k8s.io/controller-runtime/tools/[email protected]/go.mod:3: invalid go version '1.22.0': must match format 1.23 ``` This seems to be fixed by either using older envtest or newer go * golang/go#61888
|
|
|
The GHA is not running, it either needs enabling in repo settings, or approval from maintainer to run for the first time, or maybe GHAs on PR don't run until there is some existing GHA in main branch. Anyways, here's how it looks like on my fork https://github.com/jiridanek/kubezoo/actions/runs/9223347207 |
Yeah, @ddevault is right https://drewdevault.com/2023/07/04/Dont-sign-a-CLA-2.html, btw, but, after I eventually signed CLA with Oracle and got indirectly employed by IBM, every other corp is lesser evil in my eyes ;O |
SOF3
reviewed
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
testing/ci enhancements
What this PR does / why we need it:
tests and builds the project on every push and pull request, helping to maintain basic code quality
Which issue(s) this PR fixes:
the tests weren't compiling, so I also had to make changes to tests so that they compile again
Special notes for your reviewer:
the PR is meant to be squashed
followup PR will also enable e2e tests with envtest, I will have to either update go version or extensively edit Makefile to make it working (see commit message on the last commit here)