-
Notifications
You must be signed in to change notification settings - Fork 24
chore(x): adds XDl component #4228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
50003b6
to
f2c6268
Compare
Signed-off-by: John Cowen <[email protected]>
f2c6268
to
95a26cd
Compare
<script lang="ts" setup> | ||
|
||
const props = defineProps<{ | ||
variant: 'x-stack' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to align the wording to XLayout
type stack
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, definitely! but I would like to go the other way around (and I plan to) and move stack
in XLayout to y-stack
(and x-stack
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see 💡 but isn't stack
implicitly vertical? If I understand correctly in XLayout
you are planning to renaming separated
to x-stack
and stack
to y-stack
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like XLayout to have x-stack
and y-stack
i.e. "stack" horizontally or vertically
I would also like to keep XLayout's separated
which is supposed to be for laying out things in a similar way to a "comma separated list", which is inline and therefore not exactly that same as a block x-stack
Vaguely related, is that I would also like to move XLayout to use :variant
eventually.
Similar to #4191 this PR adds a thin layer over native
dl
so we can provide our own styles to adl
in a more controlled way that adding global styles and or having a class that we add to every dl.Like XTable, this component should be seen in atomic terms as an atom, i.e. the smallest possible purpose (its almost a native
dl
). In avoiding global styles and using a restricted set of:variants
we can have more control overdl
s globally across our application.As with XTable this PR includes a single implementation, once this is merged we can roll it out everywhere else.
My only slight concern about this PR is the awkward three letter name:
XDl
, however this stick consistently to the pattern of:x
components begin withX
so we never hit vue restrictions over disallowing single word components.Given the above, there is no other name we can use but
XDl