You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wanted to ask if you think we should remove the status circled in the screengrab below? We have the pattern of putting the "Status Type Thing" underneath the title so its visible no matter what tab you are on, and even before this PR it felt to me like we were doubling up data for no reason. Now we have the error message in the individual inbound card, this feels even more redundant. Wdyt? Should we remove this one? (the circled one)
Wanted to ask if you think we should remove the status circled in the screengrab below? We have the pattern of putting the "Status Type Thing" underneath the title so its visible no matter what tab you are on, and even before this PR it felt to me like we were doubling up data for no reason. Now we have the error message in the individual inbound card, this feels even more redundant. Wdyt? Should we remove this one? (the circled one)
Honestly I'd leave it as is. Having the status in the about section keeps everything related to the resource in one place and as a user I don't have to collect information that is spread on the page to gather all information about the resource. Also the Status description is more explanatory than just a badge.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
johncowen
force-pushed
the
feature/inbound-warning
branch
from
Closes #3984
Wanted to ask if you think we should remove the status circled in the screengrab below? We have the pattern of putting the "Status Type Thing" underneath the title so its visible no matter what tab you are on, and even before this PR it felt to me like we were doubling up data for no reason. Now we have the error message in the individual inbound card, this feels even more redundant. Wdyt? Should we remove this one? (the circled one)