fix: adding retry strategy in KurtosisUpgrader #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoporoli
force-pushed
the
lporoli/fix-kurtosis-upgrader
branch
2 times, most recently
from
6fd1851
to
bdf5654
Compare
leoporoli
force-pushed
the
lporoli/fix-kurtosis-upgrader
branch
from
c81a173
to
4fdc346
Compare
leoporoli
force-pushed
the
lporoli/fix-kurtosis-upgrader
branch
from
1994375
to
8df9fb4
Compare
skylarmb
approved these changes
May 30, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 30, 2024
🤖 I have created a release *beep* *boop* --- ## [0.89.13](0.89.12...0.89.13) (2024-05-30) ### Bug Fixes * adding retry strategy in KurtosisUpgrader ([#2464](#2464)) ([db899a6](db899a6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding retry strategy when calling to the
get cloud instance configendpoint in theKurtosis Upgraderbecause when the engine is restarted it won't return a response for a few secondsREMINDER: Tag Reviewers, so they get notified to review
Is this change user facing?
YES
References (if applicable)