feat: port name validation RFC-6335 #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
reviewed
Jun 6, 2024
container-engine-lib/lib/backend_interface/objects/service/service_test.go
Show resolved
Hide resolved
tedim52
approved these changes
Jun 6, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
🤖 I have created a release *beep* *boop* --- ## [0.89.17](0.89.16...0.89.17) (2024-06-07) ### Features * add optional names to tasks ([#2477](#2477)) ([5d7bb67](5d7bb67)) * port name validation RFC-6335 ([#2474](#2474)) ([ffbd30b](ffbd30b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kubernetes adheres to RFC-6335, which specifies that port names must be between 1 and 15 characters. However, this constraint is currently not enforced by the Kurtosis engine, leading to deployment failures in Kubernetes environments when port names exceed 15 characters.
Here is an example that the Kurtosis validation step failed to catch:
This PR resolves the issue by adding an additional validation step for port names. It also refactors the regex definitions in
service.goand improves the test design for validating service and port names inservice_test.go.Is this change user facing?
YES
References (if applicable)