feat: [log retention improvements pt. 2] add flag for configuring log retention period #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4ck3rk3y
reviewed
Aug 22, 2024
h4ck3rk3y
reviewed
Aug 22, 2024
h4ck3rk3y
reviewed
Aug 22, 2024
h4ck3rk3y
reviewed
Aug 22, 2024
h4ck3rk3y
approved these changes
Aug 22, 2024
Deploying kurtosis with
|
| Latest commit: |
b0d901f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1b3d2486.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://tedi-granularetention.kurtosis-docs.pages.dev |
barnabasbusa
approved these changes
Aug 29, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
🤖 I have created a release *beep* *boop* --- ## [1.2.0](1.1.0...1.2.0) (2024-08-29) ### Features * [log retention improvements pt. 2] add flag for configuring log retention period ([#2536](#2536)) ([185dc6f](185dc6f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log Retention Improvements:
This PR allows users to configure log retention period with
--log-retention-periodflag on engine starts/restarts. Default is set to 1 week.LogFileLayoutandPerWeekLogFileLayoutand adjustLogFileManagerandLogsDatabaseClientto use this for retrieving log file pathsPerHourFileLayoutand swap storage format fromPerWeekFileLayouttoPerHourFileLayoutLogsAggregatoruseLogFileLayoutfor determining storage format and set it to usePerHourFileLayoutIs this change user facing?
NO
References
#2443
#2190
#2534