feat: bucket controller #33
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PublicAccess) - also enable default CORS rules on bucket creation - support API param dynamic change of bucket name - fix fileGetUrl support expire time and bucket region
upgrade to uuid v9 was not taken into account in code use
stack trace is insufficient in plugin calling point to identify which step is causing a crash when creating a bucket
…ucket request params - this is not handled at the moment because we need to disable block public request before setting a bucket policy that makes access public. - it is then currently advided to first create the bucket, then disable blockPublicAccess, then put bucket policies in order to make sure bucket permissions are set in the right order. - it could be a feature to support proper/automatic disable of block public access based on bucket policies ? see roadmap for this plugin
… enable buckets use by default
…er' into feat/bucket-controller-mathis
fmauNeko
approved these changes
Nov 14, 2024
|
It is necessary to handle bucketRegion for every single api endpoint as it could lead to not being able to use correctly a bucket in a region other than config one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First things first : Thank you @matgardon for the contribution
PR content :