-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/event timeframes #81
base: main
Are you sure you want to change the base?
Conversation
Ser bra ut! |
Co-authored-by: Mathias Haugsbø <[email protected]>
Co-authored-by: Mathias Haugsbø <[email protected]>
Co-authored-by: Mathias Haugsbø <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary line
…rteret/kvarteret.no into enhancement/event-timeframes
This will probably be blocked until we agree on what and how to show "Dette skjer i dag" events from crescat and or studentbergen |
Co-authored-by: Mathias Haugsbø <[email protected]>
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
} |
You should enable format on save in vscode, it will automatically fix these
https://www.alphr.com/use-prettier-vs-code/
Authorization: `Bearer ${process.env.CRESCAT_TOKEN}` | ||
}); | ||
|
||
var rawShowTimes = Array(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var rawShowTimes = Array(); | |
var rawShowTimes = Array(); |
var rawShowTimes = Array(); | |
const rawShowTimes: Show_Times[][] = []; |
Use const and let instead of var in javscript
}; | ||
|
||
// Array to be returned | ||
var jsonShowTimes = Array(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var jsonShowTimes = Array(); | |
const jsonShowTimes: Show_Times[] = []; |
// Fetches json payload from the Crescat booking site | ||
const crescatData = await cachedGet("https://app.crescat.io/external/v1/calendar", { | ||
Authorization: `Bearer ${process.env.CRESCAT_TOKEN}` | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}); | |
}) as CrescatEvent[]; |
=> Then you will get great typing help
Co-authored-by: Mathias Haugsbø <[email protected]>
This is a better implementation of what i wanted. Good job :) Co-authored-by: Mathias Haugsbø <[email protected]>
No description provided.