Enhancement/event timeframes #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fullskjerm: Mobilskjerm: |
mathiash98
requested changes
Sep 14, 2022
|
Ser bra ut! |
Co-authored-by: Mathias Haugsbø <[email protected]>
Co-authored-by: Mathias Haugsbø <[email protected]>
Co-authored-by: Mathias Haugsbø <[email protected]>
…rteret/kvarteret.no into enhancement/event-timeframes
mathiash98
approved these changes
Sep 28, 2022
|
This will probably be blocked until we agree on what and how to show "Dette skjer i dag" events from crescat and or studentbergen |
Co-authored-by: Mathias Haugsbø <[email protected]>
mathiash98
requested changes
Oct 14, 2022
Comment on lines
+85
to
+86
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| } | |
| } |
You should enable format on save in vscode, it will automatically fix these
https://www.alphr.com/use-prettier-vs-code/
| Authorization: `Bearer ${process.env.CRESCAT_TOKEN}` | ||
| }); | ||
|
|
||
| var rawShowTimes = Array(); |
There was a problem hiding this comment.
Suggested change
| var rawShowTimes = Array(); | |
| var rawShowTimes = Array(); |
Suggested change
| var rawShowTimes = Array(); | |
| const rawShowTimes: Show_Times[][] = []; |
Use const and let instead of var in javscript
| }; | ||
|
|
||
| // Array to be returned | ||
| var jsonShowTimes = Array(); |
There was a problem hiding this comment.
Suggested change
| var jsonShowTimes = Array(); | |
| const jsonShowTimes: Show_Times[] = []; |
| // Fetches json payload from the Crescat booking site | ||
| const crescatData = await cachedGet("https://app.crescat.io/external/v1/calendar", { | ||
| Authorization: `Bearer ${process.env.CRESCAT_TOKEN}` | ||
| }); |
There was a problem hiding this comment.
Suggested change
| }); | |
| }) as CrescatEvent[]; |
=> Then you will get great typing help
Co-authored-by: Mathias Haugsbø <[email protected]>
This is a better implementation of what i wanted. Good job :) Co-authored-by: Mathias Haugsbø <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.