[Bugfix] fix the gid choice of IB device: only choose IBV_GID_TYPE_ROCE_V2 now #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 now Signed-off-by: fengquyoumo <[email protected]>
alogfans
reviewed
Feb 20, 2025
mooncake-transfer-engine/src/transport/rdma_transport/rdma_context.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: fengquyoumo <[email protected]>
|
@alogfans Hi ! Could you review this PR again? I’ve made the changes based on your last feedback. |
alogfans
reviewed
Mar 6, 2025
| if (is_ipv4_rival && !is_ipv4) { | ||
| if (ipv6_addr_v4mapped((struct in6_addr *)gid_entry.gid.raw) && | ||
| (gid_entry.gid_type == IBV_GID_TYPE_IB || | ||
| gid_entry.gid_type == IBV_GID_TYPE_ROCE_V2)) { |
There was a problem hiding this comment.
Look fine to me.
Some Infiniband devices do not enable IPoIB so I recommend to change these line as (notice brackets)
if ((ipv6_addr_v4mapped((struct in6_addr *)gid_entry.gid.raw) &&
gid_entry.gid_type == IBV_GID_TYPE_ROCE_V2)
|| gid_entry.gid_type == IBV_GID_TYPE_IB) {
There was a problem hiding this comment.
Adjusted. Please take a look again!
Signed-off-by: fengquyoumo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the function
RdmaContext::getBestGidIndex, we select the first GID with an IPv4-mapped address without considering the GID type.Since the connection is now TCP-based, it requires the type of GID to be RoCEv2.
Selecting a RoCEv1 GID will result in an error due to the poor connection:
Meanwhile, I also removed some code that appeared to be unnecessary.