Skip to content

[MooncakeAdaptor] Init sglang_adaptor to support SGLang using transfer engine #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2025
Merged

[MooncakeAdaptor] Init sglang_adaptor to support SGLang using transfer engine #181

merged 2 commits into from
Mar 29, 2025

Conversation

stmatengss
Copy link
Collaborator

No description provided.

@ShangmingCai ShangmingCai self-requested a review March 29, 2025 04:52
ShangmingCai
ShangmingCai approved these changes Mar 29, 2025
View reviewed changes
Copy link
Collaborator

@ShangmingCai ShangmingCai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But we might need to consider unifying the integration python lib into one. For now, it is good to go since sglang integration only requires interfaces for the transfer engine.

@ShangmingCai ShangmingCai merged commit db5929e into main Mar 29, 2025
2 checks passed
@stmatengss stmatengss mentioned this pull request Mar 31, 2025
Open
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShangmingCai ShangmingCai ShangmingCai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stmatengss @ShangmingCai