Add the ability to select Query options when looking up workout samples #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) call with SampleQueryOption parameter.
Added functionality to import AH sleep data via native categoryQuery() call with SampleQueryOption parameter
kvs-coder
force-pushed
the
master
branch
3 times, most recently
from
76f8ed3 to
6f05fe1
Compare
|
Hi @SamBergeron Sorry for a vary long absence, as I see that PR https://github.com/kvs-coder/health_kit_reporter/pull/67/files is a more refined version of this one, do you mind if I just close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Migrations
NO
Description
This PR exposes the sample query options allowing us to use them in Flutter. This resolves issues that are outlined in #69
There should be no regressions here as all this does is add an extra option to the categoryQuery in the Flutter plugin, the native extensions have been updated to accept this new argument and match the style that is applied to other methods. There is no native plugin change required. This is reverse compatible.
Related PRs
#67 This is essentially the same thing but for category imports