Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset displayed spindle angle with SET long press #4

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnsonm
Copy link

@johnsonm johnsonm commented Jan 2, 2024

Currently, spindle angle is displayed relative to the position the spindle was in when the unit was powered on. However, when using the spindle angle display mode, it would sometimes be convenient to be able to set the reference angle. Displaying the angle relative to when entering the spindle angle display mode would be a convenient way to set the index.

(Based on conversation at clough42#278, thus this PR is currently in draft status because it has not yet been tested. I'll remove the draft state after it is tested.)

@johnsonm johnsonm changed the title Display spindle angle relative to position when entering spindle angle display mode Reset displayed spindle angle with SET long press Jan 3, 2024
@johnsonm
Copy link
Author

johnsonm commented Jan 3, 2024

Modified (still untested!) based on comments at clough42#278

@ACaesuraIsStillMusic
Copy link

I added the ability to reset the spindle position as a menu option in my fork, instead of a long press.
master...ACaesuraIsStillMusic:electronic-leadscrew:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants