Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check against email (author) array to ensure this 'pusher' is allowed #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ururk
Copy link

@ururk ururk commented Mar 7, 2014

In hook.php it says:

// Adding `prod` branch to deploy for `production` to path `/var/www/testhook/prod` limiting to only `[email protected]`
$hook->addBranch('prod', 'production', '/var/www/prod', array('[email protected]'));

However, there isn't any code in class.GitHubHook.php or hook.php to prevent a different user who pushes to the branch to update the code on the server that has the deploy hook. I've added code which enables a remote pull if:

  • the author array is empty OR
  • the pusher email is in the author array

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant