iomethods and iomethods testing#118
Open
caocampb wants to merge 129 commits intokwhitehall:masterfrom
caocampb:data-read-in
Open
iomethods and iomethods testing#118caocampb wants to merge 129 commits intokwhitehall:masterfrom caocampb:data-read-in
caocampb wants to merge 129 commits intokwhitehall:masterfrom
caocampb:data-read-in
Conversation
…or userVariables.filelist
…ing an issue for userVariables.filelist
…to figure out a way to assign data from numPy array to variables dynamically. For example, currently it's hardcoded... ch4[:,:,:] = temperatures Tried to integrate read_binary_data into read_data. Needs testing and a few other things such as adding to the timelist.
Added mask to fulfill lat/lon range in read_data for binary MERG
…/lon range from numpy array
Extracted TRMM reading code, started generalizing it
…into data-read-in
| LON, LAT = np.meshgrid(lonsraw, latsraw) | ||
|
|
||
| timeName = 'time' | ||
| for file in userVariables.filelist: |
Owner
There was a problem hiding this comment.
file should be avoided as variable name. In general, please be mindful of using reserved words (in Python and other languages) for variable or method names as it also reduces readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the binary file in GTG wasn't working because of lack of understanding of how the data is used outside of it. Will take a look within the next day.
Missing doc for a few functions, will add those very soon also.