This repository was archived by the owner on Nov 11, 2023. It is now read-only.
Nullable enabled.#9
Closed
iterma wants to merge 2 commits into
Closed
Conversation
Owner
I definitely want to enable the nullable feature. Thanks for your effort to enable nullable in this repo. |
Owner
There are some indentation issues. Some files use hard tabs while others use 4 spaces. Never mind. I will fix them after we get this PR merged. (If I fix them now, we will end up resolving a lot of merge conflicts.) |
Owner
|
Close this in favor of #11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After .NET6 it's time to also enable nullable…
I've done an initial review and think I've found the sore points.
In some cases, I have entered more or less dummy values, but they cannot be worse than null reference exceptions (today).
If you are interested in this change, I will come back with a few others later, so it may be better to wait a bit longer until a new release is released. But everything is entirely up to you.
// I think that GitHub shows more differences than reality...