Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Python 3.12 wheels #203

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Build Python 3.12 wheels #203

merged 2 commits into from
Oct 5, 2023

Conversation

madig
Copy link
Contributor

@madig madig commented Oct 3, 2023

No description provided.

@HinTak
Copy link
Collaborator

HinTak commented Oct 3, 2023

I have unblocked CI. At the moment the only likely thing is timing (some stages might push over 6 hours per job). Let's see if CI catches anything else.

@HinTak
Copy link
Collaborator

HinTak commented Oct 3, 2023

CI failed. It seems that github's python action does not support 3.12 yet. Part of the log:

Build wheels on ubuntu-22.04 (aarch64) for cp312
failed 48 minutes ago in 49s
2s
12s
15s
5s
11s
Run pypa/cibuildwheel@v2.[1](https://github.com/kyamagu/skia-python/actions/runs/6395333786/job/17366861532#step:5:1)[2](https://github.com/kyamagu/skia-python/actions/runs/6395333786/job/17366861532#step:5:2).1
  with:
    package-dir: .
    output-dir: wheelhouse
  env:
    CIBW_BUILD: cp[3](https://github.com/kyamagu/skia-python/actions/runs/6395333786/job/17366861532#step:5:3)12-*
    CIBW_SKIP: *musllinux*
    CIBW_ARCHS: aarch6[4](https://github.com/kyamagu/skia-python/actions/runs/6395333786/job/17366861532#step:5:4)
    CIBW_ENVIRONMENT_MACOS: TARGET_ARCH=aarch[6](https://github.com/kyamagu/skia-python/actions/runs/6395333786/job/17366861532#step:5:6)4
    CIBW_BEFORE_ALL: bash scripts/build_Linux.sh
    CIBW_BEFORE_BUILD: pip install pybind11 numpy
    CIBW_TEST_REQUIRES: pytest pillow glfw
    CIBW_TEST_REQUIRES_MACOS: pytest pillow pyopengl
    CIBW_TEST_COMMAND: python -m pytest {project}/tests
    CIBW_TEST_COMMAND_LINUX: xvfb-run -s "-screen 0 640x480x24" python -m pytest {project}/tests
  
    CIBW_TEST_SKIP: *-macosx_arm64
Run actions/setup-python@v4
  with:
    python-version: 3.[7](https://github.com/kyamagu/skia-python/actions/runs/6395333786/job/17366861532#step:5:7) - 3.[11](https://github.com/kyamagu/skia-python/actions/runs/6395333786/job/17366861532#step:5:11)
    update-environment: false
    check-latest: false
    token: ***
    allow-prereleases: false
...
cibuildwheel: No build identifiers selected: BuildSelector(build_config='cp312-*', skip_config='*musllinux*', requires_python=None, prerelease_pythons=False)
Error: Process completed with exit code 3.

See the line after actions/setup-python@v4.

@HinTak
Copy link
Collaborator

HinTak commented Oct 3, 2023

Okay, python 3.12 was released yesterday - so it is not available anywhere yet.

@anthrotype
Copy link

cibuildwheel installs its own pythons, I think you just need to make sure cibuildwheel is up to date, it definitely can build 3.12 wheels

@HinTak
Copy link
Collaborator

HinTak commented Oct 3, 2023

CI failed. So this cannot be merged (yet).

@HinTak
Copy link
Collaborator

HinTak commented Oct 3, 2023

logs_61.zip

CI log. Please fix

@kyamagu
Copy link
Owner

kyamagu commented Oct 4, 2023

Yes, this requires the up-to-date cibuildwheel
https://github.com/pypa/cibuildwheel/releases

Copy link
Collaborator

@HinTak HinTak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI finished

@HinTak HinTak merged commit dcba39e into kyamagu:main Oct 5, 2023
14 checks passed
@madig madig deleted the build-cp312 branch October 6, 2023 10:08
@HinTak HinTak mentioned this pull request Oct 13, 2023
This was referenced Nov 26, 2023
@HinTak HinTak mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants